Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable BusyBox Related NTP Services #749

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Disable BusyBox Related NTP Services #749

merged 1 commit into from
Oct 22, 2024

Conversation

axkar
Copy link
Collaborator

@axkar axkar commented Oct 21, 2024

When it comes to NTP services, Infix completely relies on Chrony. All other (BusyBox) NTP services should be disabled

Checklist

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Test changes
    • Checked in changed Readme.adoc (make test-spec)
    • Added new test to group Readme.adoc and yaml file
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
    • ChangeLog updated (for major changes)
  • Other (please describe):

@axkar axkar requested a review from troglobit October 21, 2024 13:56
@axkar axkar self-assigned this Oct 21, 2024
Copy link
Contributor

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sooo sorry, I realize now I should have explained this task a little bit more in detail! 😥

What you need to do is run:

make busybox-menuconfig

disable relevant parts for the keyword 'NTP'. (Seach by tapping '/') And the save and exit busybox's menuconfig. Then you call

make busybox-update-config

Which tells Buildroot to update the common BusyBox defconfig, somewhere down in board/common/. Check with git status and verify with git diff that only *NTP* related changes were made.


Background

BusyBox is a collection of small implementations of common UNIX/Linux utilities, commands, and daemons (services). Usually built as a single "multicall binary"1

So you actually don't have to touch these files in your current PR at all. The whole skeleton-init-finit package actually adapts to other package selections in Buildroot and Infix as a whole. (I periodically synchronize it with https://github.com/troglobit/finit-skel)

Footnotes

  1. A multicall binary has all tools built into one, and if you create a symlink to /usr/bin/busybox, e.g., ls and then call ls, the busybox binary detects it's called with another name and, in this case, calls ls_main(). This saves a LOT of space in embedded systems since you only need one ELF header for the single binary. In fact, many embedded systems can make do with just that on top of an equally stripped Linux kernel.

@axkar
Copy link
Collaborator Author

axkar commented Oct 22, 2024

Thank you for the thorough description. I think I made it this time. Please have another look :)

@axkar axkar requested a review from troglobit October 22, 2024 13:05
Copy link
Contributor

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@axkar axkar merged commit 52eafa7 into main Oct 22, 2024
5 checks passed
@axkar axkar deleted the disable-ntpd branch October 22, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants