Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update dhcp test topologies #760

Merged
merged 1 commit into from
Oct 24, 2024
Merged

test: update dhcp test topologies #760

merged 1 commit into from
Oct 24, 2024

Conversation

axkar
Copy link
Collaborator

@axkar axkar commented Oct 23, 2024

Minor update on dhcp test case. Primarily changes in topology.dot file:

  • link colors
  • ip address rearrangement

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Test changes
    • Checked in changed Readme.adoc (make test-spec)
    • Added new test to group Readme.adoc and yaml file
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
    • ChangeLog updated (for major changes)
  • Other (please describe):

@axkar axkar requested review from troglobit and mattiaswal and removed request for troglobit October 23, 2024 13:42
Copy link
Contributor

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I prefer double spaced sentences, it helps with the tooling I use for writing (Emacs), which supports automatic reflow of paragraphs to max column width. I also think it's easier to read in monospaced text, i.e., in the editor.

@axkar
Copy link
Collaborator Author

axkar commented Oct 23, 2024

Personally I prefer double spaced sentences, it helps with the tooling I use for writing (Emacs), which supports automatic reflow of paragraphs to max column width. I also think it's easier to read in monospaced text, i.e., in the editor.

Sounds like a good enough reason to revert it :)
Thnx for having a look

@troglobit
Copy link
Contributor

Personally I prefer double spaced sentences, it helps with the tooling I use for writing (Emacs), which supports automatic reflow of paragraphs to max column width. I also think it's easier to read in monospaced text, i.e., in the editor.

Sounds like a good enough reason to revert it :) Thnx for having a look

I like the grammar fix though, very much. I.e, the added missing comma 😃

@axkar axkar merged commit 04c843e into main Oct 24, 2024
4 checks passed
@axkar axkar deleted the update-dhcp-tests branch October 24, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants