Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Running Infix Tests from External Projects #764

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Simplify Running Infix Tests from External Projects #764

merged 1 commit into from
Oct 25, 2024

Conversation

axkar
Copy link
Collaborator

@axkar axkar commented Oct 24, 2024

This will facilitate running infix tests from external projects:

  • eliminate the need for an external topology.dot.in file
  • eliminate the requirement to manually provide external image name

Fixes #763

Checklist

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Test changes
    • Checked in changed Readme.adoc (make test-spec)
    • Added new test to group Readme.adoc and yaml file
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
    • ChangeLog updated (for major changes)
  • Other (please describe):

@axkar axkar requested a review from wkz October 24, 2024 14:51
@axkar axkar self-assigned this Oct 24, 2024
wkz
wkz approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@wkz wkz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So great that upper trees won't have to think about this at all anymore!

I added some minor comments. Your choice whether you fix them or not 😄

test/test.mk Outdated Show resolved Hide resolved
wkz
wkz reviewed Oct 25, 2024
View reviewed changes
test/test.mk Outdated Show resolved Hide resolved
@axkar
test: simplify running infix tests from external
3b2bdbf 
This will facilitate running infix tests from external projects:
  - eliminate the need for an external topology.dot.in file
  - eliminate the requirement to manually provide external image name

Fixes kernelkit#763
@axkar axkar merged commit 55a20bb into kernelkit:main Oct 25, 2024
4 checks passed
@axkar axkar deleted the update-infix-test branch October 25, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkz wkz wkz approved these changes

Assignees

@axkar axkar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify running infix tests from external projects
2 participants
@axkar @wkz