Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove etherlike #940

Merged
merged 3 commits into from
Feb 14, 2025
Merged

Remove etherlike #940

merged 3 commits into from
Feb 14, 2025

Conversation

mattiaswal
Copy link
Contributor

Description

Checklist

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Test changes
    • Checked in changed Readme.adoc (make test-spec)
    • Added new test to group Readme.adoc and yaml file
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
    • ChangeLog updated (for major changes)
  • Other (please describe):

@mattiaswal mattiaswal marked this pull request as draft February 11, 2025 19:44
@mattiaswal mattiaswal force-pushed the remove-etherlike branch 2 times, most recently from 033c479 to 61db85d Compare February 12, 2025 20:01
@mattiaswal mattiaswal requested a review from wkz February 13, 2025 15:02
@mattiaswal mattiaswal force-pushed the remove-etherlike branch 2 times, most recently from 00e1826 to 470055e Compare February 13, 2025 19:03
wkz
wkz requested changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@wkz wkz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So nice to get rid of this - awesome! 🎉

I think we either need a mention of this breaking change in the changelog, or a bump the confd version and add a migrate script.

@mattiaswal
yanger: Refactor how ethtool is read from interfaces
2d806de 
Upgrade ethtool to get json support for main command:

ethtool --json eth1
@mattiaswal
Remove interface type Etherlike
b290e44 
Instead check if the interface support autonegotion
before setting it to an interface.

This fix #877 and fix #584
@mattiaswal
Migrate configuration for etherlike
31d0f79 
Migrate infix-if-type:etherlike in configuration to infix-if-type:ethernet
@mattiaswal mattiaswal marked this pull request as ready for review February 14, 2025 09:12
@mattiaswal mattiaswal requested a review from wkz February 14, 2025 09:12
@wkz wkz merged commit eee1ce3 into main Feb 14, 2025
5 of 6 checks passed
@wkz wkz deleted the remove-etherlike branch February 14, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkz wkz wkz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattiaswal @wkz