-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reformat renatoliveira's patch #30
base: master
Are you sure you want to change the base?
Conversation
…ts to bypass methods, rearrange slightly for consistency
public static void showLimits() { | ||
showLimits = true; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overloaded to allow for calling method with a boolean. This allows toggling off.
public static void showLimits() { | |
showLimits = true; | |
} | |
public static void showLimits() { | |
showLimits(true); | |
} | |
public static void showLimits(Boolean enabled) { | |
showLimits = enabled; | |
} |
Yes, I thought it was odd it couldn't be turned off, but didn't think enough to change it. :) Fixed. I also fixed the global bypass example in the README. |
@vr8hub No problem. Thanks for the fix. Looks like there is a merge conflict that needs to be resolved before merging. If you can take care of that I can get this merged. |
Well, I'm out of my depth, apparently. I've never had something change underneath me on a PR. |
I finally had time to investigate this and believe the conflicts are resolved. |
This started out as a reformatted PR#13 per the request from @kevinohara80 there. (I asked there if renatoliveira was OK with me submitting a reformatted version, and he said he was). I added the following changes: