Skip to content

Commit

Permalink
ci: Test earliest supported Node.js version
Browse files Browse the repository at this point in the history
If we claim to support Node.js 18.0 in package.json#engines.node, we
should test that version in CI.  It's easy to inadvertently depend on
features which were backported to Node.js 18, but are not present in
early 18.x versions, thereby breaking deployments which use an older
version.  Any such breakage should be a semver major change reflected in
package.json#engines.node.

Signed-off-by: Kevin Locke <[email protected]>
  • Loading branch information
kevinoid committed Nov 2, 2024
1 parent c114513 commit 8919477
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ jobs:
- ubuntu-latest
- windows-latest
node:
- '18'
- '18.0'
- latest
exclude:
# Exclude os/version already run in test-primary
Expand Down

0 comments on commit 8919477

Please sign in to comment.