Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates in Allegro Ecal needed for Pandora #410

Closed
wants to merge 1 commit into from
Closed

Updates in Allegro Ecal needed for Pandora #410

wants to merge 1 commit into from

Conversation

faltovaj
Copy link
Contributor

@faltovaj faltovaj commented Nov 13, 2024 •
edited
Loading

BEGINRELEASENOTES

  • Fix the segmentation type in CLD_o4_v05/LAr_ECalBarrel.xml
  • Added material description per layer (interaction and radiation lengths) needed for Pandora in ECalBarrel_NobleLiquid_InclinedTrapezoids_o1_v03_geo.cpp and ECalBarrel_NobleLiquid_InclinedTrapezoids_o1_v04_geo.cpp

ENDRELEASENOTES

@andresailer
Copy link
Contributor

Dear @faltovaj

Please keep the BEGIN/ENDRELEASENOTES lines.

Thanks

@faltovaj
Copy link
Contributor Author

faltovaj commented Nov 13, 2024 •
edited
Loading

Dear @faltovaj

Please keep the BEGIN/ENDRELEASENOTES lines.

Thanks

I'm sorry for that, fixed now.

@SwathiSasikumar
Copy link
Contributor

SwathiSasikumar commented Nov 13, 2024 •
edited
Loading

The changes in LAr_ECalBarrel.xml and ECalBarrel_NobleLiquid_InclinedTrapezoids_o1_v03_geo.cpp were already requested in PR #361. Maybe we close that one first? I will finalize the last request by Brieuc and update it.

@faltovaj
Copy link
Contributor Author

The changes in LAr_ECalBarrel.xml and ECalBarrel_NobleLiquid_InclinedTrapezoids_o1_v03_geo.cpp were already requested in PR #361. Maybe we close that one first? I will finalize the last request by Brieuc and update it.

I found another PR #382 implementing the change in LAr_ECalBarrel.xml. This should be closed as well ....

@BrieucF
Copy link
Contributor

BrieucF commented Nov 14, 2024

Handled by #361

@BrieucF BrieucF closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SwathiSasikumar SwathiSasikumar Awaiting requested review from SwathiSasikumar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@faltovaj @andresailer @SwathiSasikumar @BrieucF