Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer internal channels #189

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

buffer internal channels #189

wants to merge 2 commits into from

Conversation

joshblum
Copy link
Member

@joshblum joshblum commented Apr 7, 2020

Buffer internal queues and process writes in a routine. Relates to keybase/client#23530

cc @strib

@joshblum joshblum requested a review from mmaxim April 7, 2020 18:33
@jzila
Copy link

jzila commented Apr 7, 2020

Is the 100 buffer size arbitrary? If so, can try a solution like this: https://github.com/keybase/client/blob/master/go/kbfs/libkbfs/channels.go

@joshblum joshblum mentioned this pull request Apr 9, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmaxim mmaxim Awaiting requested review from mmaxim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshblum @jzila