Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add possibility to run rosa-cross-dc deployment from KC repository an… #693

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Add possibility to run rosa-cross-dc deployment from KC repository an… #693

merged 1 commit into from
Jan 23, 2024

Conversation

mhajas
Copy link
Contributor

@mhajas mhajas commented Jan 22, 2024 •
edited
Loading

…d branch

Here is an example run of the changes in GHA: https://github.com/mhajas/keycloak-benchmark/actions/runs/7610623422/job/20724345702 for release/23.0 branch from upstream Keycloak.

Closes #522
Signed-off-by: Michal Hajas [email protected]

@mhajas mhajas requested a review from kami619 January 22, 2024 13:48
@kami619
Copy link
Contributor

kami619 commented Jan 23, 2024

it works, thanks for guiding me through this @mhajas.


task: [utils:patch-keycloak-operator-image] (test -n "image-registry.openshift-image-registry.svc:5000/kamesh-keycloak/keycloak-operator:latest" && KUBECONFIG="/Users/kameswararaoakella/.kube/config" kubectl patch deployment keycloak-operator -n kamesh-keycloak --type json -p '[{"op": "replace", "path": "/spec/template/spec/containers/0/image", "value": "image-registry.openshift-image-registry.svc:5000/kamesh-keycloak/keycloak-operator:latest"}]') || true

@mhajas mhajas force-pushed the 522-Simplified-image-building-for-KC22-specific-changes-for-Cross-DC-actitivies branch 2 times, most recently from 3ffe74f to 6e1c2a5 Compare January 23, 2024 12:28
@mhajas mhajas force-pushed the 522-Simplified-image-building-for-KC22-specific-changes-for-Cross-DC-actitivies branch from 6e1c2a5 to b5d6d59 Compare January 23, 2024 12:55
kami619
kami619 approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@kami619 kami619 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kami619 kami619 merged commit 15105a9 into keycloak:main Jan 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kami619 kami619 kami619 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplified image building for KC22 specific changes for Cross-DC actitivies
2 participants
@mhajas @kami619