Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new remote-store options #711

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

pruivo
Copy link
Contributor

@pruivo pruivo commented Feb 8, 2024

Depends on

Relates to:

I also changed the provision/rosa-cross-dc/Taskfile.yaml to deploy Keycloak in parallel in both ROSA clusters.

@pruivo
Copy link
Contributor Author

pruivo commented Feb 8, 2024

Custom Keycloak image available here: quay.io/pruivo/keycloak:gh-25676
Contains keycloak/keycloak#26756 + infinispan/infinispan#11942 (kind of)

@ahus1 ahus1 force-pushed the t_remote_store_cli_options branch from 3970213 to 873ca60 Compare February 28, 2024 14:26
@mhajas
Copy link
Contributor

mhajas commented Feb 29, 2024

We probably can't merge this until this:

<!-- This is a workaround for the following issue https://github.com/keycloak/keycloak/issues/27117 and should be removed when the issue is fixed -->
<write-behind modification-queue-size="1024"/>
<!-- End of the workaround -->

is needed

@ahus1
Copy link
Contributor

ahus1 commented Feb 29, 2024

I know ... and we wouldn't merge this before KC24 is release as we would also need to update the documentation at the same time?

I was planning to create a PR to add this to the Java code that it adds the workaround as well. But not today, only tomorrow.

@pruivo pruivo force-pushed the t_remote_store_cli_options branch 2 times, most recently from baa7e76 to efd4bbe Compare March 6, 2024 16:05
@pruivo pruivo force-pushed the t_remote_store_cli_options branch from efd4bbe to 845bea8 Compare March 13, 2024 17:39
@pruivo pruivo marked this pull request as ready for review March 13, 2024 17:39
@pruivo
Copy link
Contributor Author

pruivo commented Mar 13, 2024

This should be ready for review as well.

@ahus1 ahus1 force-pushed the t_remote_store_cli_options branch from 845bea8 to da0fbd8 Compare March 14, 2024 13:45
@ahus1 ahus1 self-requested a review March 14, 2024 13:45
@ahus1 ahus1 self-assigned this Mar 14, 2024
@ahus1 ahus1 merged commit 36d4f86 into keycloak:main Mar 14, 2024
3 checks passed
@ahus1
Copy link
Contributor

ahus1 commented Mar 14, 2024

Tested with openshift / minikube / rosss cross dc setup, smoke tests work. Thanks!

@pruivo pruivo deleted the t_remote_store_cli_options branch March 14, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants