Add initial SQL support #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kezhuw
force-pushed
the
sql
branch
2 times, most recently
from
29c934d to
ca06fdc
Compare
Additionally, this commit introduces(a.k.a. mixes) a number of changes. 1. `TabletClient::scope` to namespace keys, and `KvClient` to unify kv operations. Resolves #16. 2. Use `Status::details` to carry `BatchError`. We probably should enhance it to full featured grpc compatible solution. Resolves #17. Resolves #24.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, this commit introduces(a.k.a. mixes) a number of changes.
TabletClient::scopeto namespace keys, andKvClientto unify kvoperations. Resolves Exported kv client to whole kv keyspace #16.
Status::detailsto carryBatchError. We probably shouldenhance it to full featured grpc compatible solution. Resolves Carry detailed error response in metadata of tonic::Status #17.
Resolves #24.