Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce named global executor for choice in execution #2

Merged
merged 1 commit into from
May 6, 2024

Conversation

kezhuw
Copy link
Owner

@kezhuw kezhuw commented May 6, 2024

It is a good for binary crate to active at most one global spawner
compat. But it could be relatively hard if dependency graph is large.
In this case, it would be good to offer choices in execution.

This commit uses environment variable SPAWNS_GLOBAL_EXECUTOR to choose
one in absent of thread context spawners.

It is a good for binary crate to active at most one global spawner
compat. But it could be relatively hard if dependency graph is large.
In this case, it would be good to offer choices in execution.

This commit uses environment variable SPAWNS_GLOBAL_EXECUTOR to choose
one in absent of thread context spawners.
@kezhuw kezhuw force-pushed the named-global-spawner branch from 13c8567 to 63a7afb Compare May 6, 2024 11:06
Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 96.92308% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 95.27%. Comparing base (3f38b2d) to head (63a7afb).

Files Patch % Lines
spawns-core/src/compat.rs 95.91% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
- Coverage   95.28%   95.27%   -0.02%     
==========================================
  Files           7        7              
  Lines         954      994      +40     
==========================================
+ Hits          909      947      +38     
- Misses         45       47       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kezhuw kezhuw merged commit 69a7121 into master May 6, 2024
15 checks passed
@kezhuw kezhuw deleted the named-global-spawner branch May 6, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant