Adding a new Power message #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ideal would probably be to add fields to Sense, but we can't do that until Indigo, now that there are Hydro firmwares in the wild.
|
Can we add this message and immediately flag as deprecated? Then, once we start working on indigo-devel, we can do #2. |
|
If we add it here, I'd rather just stick to it. Seems like an unnecessary pain to make firmware changes and then make more changes in a few months. A possible justification is publishing Sense at 10Hz vs. Power at 1Hz. |
|
Its probably okay to change firmware everytime there is a ROS-upgrade. The frequency difference justification also makes some sense. I'll merge and cut a release early this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ideal would probably be to add fields to Sense, but we can't do that until Indigo, now that there are Hydro firmwares in the wild.
Alternative would be to make breaking changes in an indigo-devel branch, and install them via source workspace on Hydro boats who want it, in advance of the full Indigo Kingfisher release.
@pmukherj, @rgariepy, thoughts on this?