Skip to content
This repository has been archived by the owner on Feb 1, 2020. It is now read-only.

Smt changes for EVM verification. #2373

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

bmmoore
Copy link
Member

@bmmoore bmmoore commented Nov 16, 2017

This adds a missing smtlib attribute necessary for EVM verification, and changes how Z3 presents implications in a way that helps some EVM proofs. For some reason, calling check-sat between asserting the antecedent of an implication and asserting the negation of the consequent allows some things to be proved quickly which would instead timeout (it helps even when the first check-sat call returns "unknown", and other commands that should try to do some solving like (apply smt) do not provide the same benefit).

@bmmoore
Copy link
Member Author

bmmoore commented Nov 17, 2017

Earlier comments on these changes are at #2369. This rebases and removes some of the changes.

@ehildenb
Copy link
Member

ehildenb commented Nov 20, 2017

@bmmoore I would like to merge this today, but I can't seem to find the relevant branch to rebase on master before merging. There are branches smt and bmmoore/smt, but it appears this PR comes from bmmoore:smt instead (perhaps a different repository)? Either way, can you rebase on master so that we can run the tests on the actual worktree that master will become?

Also, if the other branchs smt and bmmoore/smt are subsumed by this, please delete them.

@msaxena2 msaxena2 mentioned this pull request Dec 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants