Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle the built-in tzdata #14

Merged
merged 1 commit into from
Aug 25, 2024
Merged

Bundle the built-in tzdata #14

merged 1 commit into from
Aug 25, 2024

Conversation

kgaughan
Copy link
Owner

@kgaughan kgaughan commented Aug 25, 2024

This is just in case somebody wants to deploy this somewhere without timezone data installed. It'll act as a fallback.

Summary by Sourcery

Bundle the built-in timezone data in the build process to ensure the application can run without relying on external timezone data installations.

Build:

  • Add the 'timetzdata' build tag to the Makefile to include timezone data in the build.

CI:

  • Update .goreleaser.yaml to include the 'timetzdata' tag in the build configuration.

This is just in case somebody wants to deploy this somewhere without
timezone data installed. It'll act as a fallback.
Copy link

sourcery-ai bot commented Aug 25, 2024

Reviewer's Guide by Sourcery

This pull request bundles the built-in timezone data into the application by modifying the build process in the Makefile and .goreleaser.yaml file. The change ensures that the application can function correctly even when deployed in environments without timezone data installed.

File-Level Changes

Change Details Files
Add 'timetzdata' build tag to include built-in timezone data
  • Add 'timetzdata' build tag to the go build command in Makefile
  • Add 'timetzdata' build tag to the builds section in .goreleaser.yaml
Makefile
.goreleaser.yaml

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@kgaughan kgaughan merged commit a2da303 into master Aug 25, 2024
4 checks passed
@kgaughan kgaughan deleted the tzdata branch August 25, 2024 17:08
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kgaughan - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a brief comment in the Makefile explaining the purpose of the 'timetzdata' tag, to improve maintainability for future developers.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant