Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update timezone table #7

Merged
merged 2 commits into from
Jul 13, 2024
Merged

Update timezone table #7

merged 2 commits into from
Jul 13, 2024

Conversation

kgaughan
Copy link
Owner

@kgaughan kgaughan commented Jul 13, 2024

Summary by Sourcery

This pull request updates the timezone mapping for 'centralasiastandardtime' and modifies the linter configuration in the .golangci.yaml file.

  • Enhancements:
    • Updated the timezone mapping for 'centralasiastandardtime' from 'Asia/Almaty' to 'Asia/Bishkek'.
  • Build:
    • Modified .golangci.yaml to replace 'goerr113' linter with 'err113'.

Copy link

sourcery-ai bot commented Jul 13, 2024

Reviewer's Guide by Sourcery

This pull request updates the timezone table and modifies the linter configuration. Specifically, it changes the mapping for 'centralasiastandardtime' in 'zones.go' and updates the linter list in '.golangci.yaml' by adding 'err113' and removing 'goerr113'.

File-Level Changes

Files Changes
.golangci.yaml Updated the list of linters by adding 'err113' and removing 'goerr113'.
zones.go Modified the timezone mapping for 'centralasiastandardtime'.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kgaughan - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@kgaughan kgaughan merged commit 2601f8a into master Jul 13, 2024
4 checks passed
@kgaughan kgaughan deleted the update-zones branch July 13, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant