-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Windows ARM64 builds #9
Conversation
Reviewer's Guide by SourceryThis pull request addresses the issue of building the project for Windows ARM64 by updating the Go version and adding support for additional operating systems in the build configuration. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kgaughan - I've reviewed your changes - here's some feedback:
Overall Comments:
- The PR title 'Fix Windows ARM64 builds' doesn't match the actual changes in the diff. Consider updating the title to reflect the addition of FreeBSD and NetBSD support, and the Go version update.
- The Go version update from 1.13 to 1.18 is significant. Please document any potential impacts or necessary adjustments due to this change.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
@@ -1,3 +1,3 @@ | |||
module github.com/kgaughan/nxtp | |||
|
|||
go 1.13 | |||
go 1.18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (performance): Consider leveraging Go 1.18 features for potential performance improvements
The update to Go 1.18 introduces new features and optimizations. Consider reviewing the codebase for opportunities to leverage these improvements, particularly in performance-critical sections.
go 1.18 | |
go 1.18 | |
require ( | |
golang.org/x/exp v0.0.0-20220307190741-03d1a6da7d0b // for new experimental features | |
) | |
replace golang.org/x/exp => golang.org/x/exp v0.0.0-20220307190741-03d1a6da7d0b |
Summary by Sourcery
This pull request updates the build configuration to include support for FreeBSD and NetBSD, and upgrades the Go version from 1.13 to 1.18.