simplify logical expression

khyatimahendru · Dec 9, 2024 · f5fb4c2 · f5fb4c2
1 parent 73b82df
commit f5fb4c2
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/validator/src/main/java/com/google/daq/mqtt/util/ConfigManager.java b/validator/src/main/java/com/google/daq/mqtt/util/ConfigManager.java
@@ -293,10 +293,9 @@ private DiscoveryConfig getDiscoveryConfig() {
         FamilyDiscoveryModel familyDiscoveryModel = metadata.discovery.families.get(family);
         if (familyDiscoveryModel != null) {
           // for a sporadic scan, supplying generation is invalid
-          if (familyDiscoveryModel.scan_interval_sec == null) {
-            checkState(familyDiscoveryModel.generation == null,
-                "generation specified without scan_interval_sec parameter");
-          }
+          checkState(familyDiscoveryModel.scan_interval_sec != null ||
+              familyDiscoveryModel.generation == null,
+              "generation specified without scan_interval_sec parameter");
 
           FamilyDiscoveryConfig familyDiscoveryConfig = new FamilyDiscoveryConfig();
           familyDiscoveryConfig.generation = familyDiscoveryModel.generation;