Skip to content

Commit

Permalink
[Ingest Pipelines] Update copy in Manage processors (elastic#196923)
Browse files Browse the repository at this point in the history
## Summary

This PR adds some copy changes to the Manage processors pages.

1. Empty prompt
- Width and padding of the prompt is adjusted so that "IP" in the title
starts in the 2nd line
- Description is updated
<img width="800" alt="Screenshot 2024-10-18 at 17 00 53"
src="https://github.com/user-attachments/assets/51aa6cdc-5eb4-4c54-8960-7ee273d82ef5">

2. Add database modal
- Copy in callouts is updated
- The help text of the "Type" field is updated
- The text in the "Database already exists" error callout is updated
<img width="1490" alt="Screenshot 2024-10-21 at 09 34 12"
src="https://github.com/user-attachments/assets/ab3c2e21-4457-435f-a4c3-874c6edcb2ce">
<img width="1498" alt="Screenshot 2024-10-18 at 17 24 43"
src="https://github.com/user-attachments/assets/a0c15f5d-9360-4ee7-806d-2b5b64b6fd2a">

3. Manage processors page
- The title of the page is changed from "GeoIP" to "IP Location"
<img width="800" alt="Screenshot 2024-10-18 at 17 20 01"
src="https://github.com/user-attachments/assets/cde8b070-9664-42df-b71a-723a5356d4a2">

(cherry picked from commit 996eb73)
  • Loading branch information
ElenaStoeva committed Oct 22, 2024
1 parent 62a48fe commit 3334285
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ export const AddDatabaseModal = ({
helpText={
<FormattedMessage
id="xpack.ingestPipelines.manageProcessors.geoip.addDatabaseForm.databaseTypeSelectHelpText"
defaultMessage="Select which provider you want to use"
defaultMessage="Select the provider you want to use."
/>
}
>
Expand All @@ -156,15 +156,15 @@ export const AddDatabaseModal = ({
title={
<FormattedMessage
id="xpack.ingestPipelines.manageProcessors.geoip.licenseCalloutTitle"
defaultMessage="Add your MaxMind license key to keystore"
defaultMessage="Add your MaxMind license token to the keystore"
/>
}
iconType="iInCircle"
>
<p>
<FormattedMessage
id="xpack.ingestPipelines.manageProcessors.geoip.licenseCalloutText"
defaultMessage="In order to grant access to your MaxMind account, you must add the license key to the keystore."
defaultMessage="The processor needs the license key to connect to the database."
/>
</p>
</EuiCallOut>
Expand All @@ -178,15 +178,15 @@ export const AddDatabaseModal = ({
title={
<FormattedMessage
id="xpack.ingestPipelines.manageProcessors.geoip.licenseCalloutTitle"
defaultMessage="Add your IP Info license token to keystore"
defaultMessage="Add your IP Info license token to the keystore"
/>
}
iconType="iInCircle"
>
<p>
<FormattedMessage
id="xpack.ingestPipelines.manageProcessors.geoip.licenseCalloutText"
defaultMessage="In order to grant access to your IP Info account, you must add the license token to the keystore."
defaultMessage="The processor needs the license key to connect to the database."
/>
</p>
</EuiCallOut>
Expand Down Expand Up @@ -246,7 +246,7 @@ export const AddDatabaseModal = ({
<p>
<FormattedMessage
id="xpack.ingestPipelines.manageProcessors.geoip.nameExistsErrorText"
defaultMessage="Database cannot be added multiple times."
defaultMessage="A database needs to be added only once in order to be available."
/>
</p>
</EuiCallOut>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import { EuiPageTemplate } from '@elastic/eui';
import { FormattedMessage } from '@kbn/i18n-react';
import React from 'react';
import { css } from '@emotion/react/dist/emotion-react.cjs';

export const EmptyList = ({ addDatabaseButton }: { addDatabaseButton: JSX.Element }) => {
return (
Expand All @@ -26,11 +27,15 @@ export const EmptyList = ({ addDatabaseButton }: { addDatabaseButton: JSX.Elemen
<p>
<FormattedMessage
id="xpack.ingestPipelines.manageProcessors.geoip.emptyPromptDescription"
defaultMessage="Use a custom database when setting up IP Location processor."
defaultMessage="Set up a connection to a custom database when setting up IP Location processor."
/>
</p>
}
actions={addDatabaseButton}
css={css`
width: 450px;
padding: 0 20px 0 20px;
`}
/>
);
};
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ export const GeoipList: React.FunctionComponent = () => {
<h2>
<FormattedMessage
id="xpack.ingestPipelines.manageProcessors.geoip.tableTitle"
defaultMessage="GeoIP"
defaultMessage="IP Location"
/>
</h2>
</EuiTitle>
Expand Down

0 comments on commit 3334285

Please sign in to comment.