Skip to content

Commit

Permalink
[8.x] [Discover] Unskip vis tests (elastic#194020) (elastic#194121)
Browse files Browse the repository at this point in the history
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Discover] Unskip vis tests
(elastic#194020)](elastic#194020)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julia
Rechkunova","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-26T11:36:41Z","message":"[Discover]
Unskip vis tests (elastic#194020)\n\n- Closees
https://github.com/elastic/kibana/issues/184600","sha":"e1f90cc39342e668f1831271f3a6b8fc47411e74","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:DataDiscovery","backport:prev-minor"],"title":"[Discover]
Unskip vis
tests","number":194020,"url":"https://github.com/elastic/kibana/pull/194020","mergeCommit":{"message":"[Discover]
Unskip vis tests (elastic#194020)\n\n- Closees
https://github.com/elastic/kibana/issues/184600","sha":"e1f90cc39342e668f1831271f3a6b8fc47411e74"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194020","number":194020,"mergeCommit":{"message":"[Discover]
Unskip vis tests (elastic#194020)\n\n- Closees
https://github.com/elastic/kibana/issues/184600","sha":"e1f90cc39342e668f1831271f3a6b8fc47411e74"}}]}]
BACKPORT-->

Co-authored-by: Julia Rechkunova <[email protected]>
  • Loading branch information
kibanamachine and jughosta authored Sep 26, 2024
1 parent 370806a commit f913d39
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions test/functional/apps/discover/group3/_lens_vis.ts
Original file line number Diff line number Diff line change
Expand Up @@ -173,10 +173,13 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
hasTimeField: true,
changeTimestampField: `--- I don't want to use the time filter ---`,
});
await header.waitUntilLoadingHasFinished();
await discover.waitUntilSearchingHasFinished();
await checkNoVis(defaultTotalCount);

await dataViews.editFromSearchBar({ newName: 'logs', newTimeField: '@timestamp' });
await header.waitUntilLoadingHasFinished();
await discover.waitUntilSearchingHasFinished();
await checkHistogramVis(defaultTimespan, defaultTotalCount);
expect(await discover.getVisContextSuggestionType()).to.be('histogramForDataView');
});
Expand Down

0 comments on commit f913d39

Please sign in to comment.