[NOMERGE] [UNTESTED] Require a word boundary after a mention #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@[email protected]@ateohhoaush
being processed as a mention bugs me. The testing needs to be way more thorough, but it’s a start. Reallly it ought to be the start of more careful determintation of what can count as a mentiion.THIS HAS NOT BEEN TESTED. GlitchCat is not even running this code yet.
Some thoughts for later
An idea that is not necessarily trivial: allow
i think @alpha/@beta would be well suited to this
. This is tricky becausehttps://twitter.com/@beta
should never be processed as a mention, which is probably why MENTION_RE forbids an immediately preceding/
. However:Which is absolutely a bug. Here is the JSON of that status: