MBL-1974 Project notice #2214

ycheng-kickstarter · 2025-01-28T21:48:23Z

📲 What

For projects that Trust & Safety have flagged as problematic, display a "Kickstarter has restricted this creator" alert on the project overview. When the user clicks on the Learn More button, open up a bottom sheet with more information.

🤔 Why

Let users know we are doing something about sus creators.

🛠 How

Add new projectNotice field to GraphQL project fetch and Project data model
Create new reusable KSOutlinedButton
Create new reusable KSImageTextCtaBanner
Create new reusable KSBottomSheetDialogFragment and KSBottomSheetContent
Add banner ComposeView to ProjectOverviewFragment and add logic to open bottom sheet
Translations
Tests

👀 See

Light	Dark

📋 QA

Use this project on staging: https://staging.kickstarter.com/projects/clayospice/clayo-gourmet-peruvian-goods

Story 📖

https://kickstarter.atlassian.net/browse/MBL-1974

codecov-commenter · 2025-01-29T19:01:54Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 42.85714% with 80 lines in your changes missing coverage. Please review.

Project coverage is 68.21%. Comparing base (b6ab5da) to head (87ad553).

Files with missing lines	Patch %	Lines
...kstarter/ui/views/compose/KSColorAccentedBanner.kt	0.00%	58 Missing ⚠️
.../views/compose/projectpage/KSBottomSheetContent.kt	74.62%	12 Missing and 5 partials ⚠️
...arter/services/transformers/GraphQLTransformers.kt	0.00%	4 Missing ⚠️
...pp/src/main/java/com/kickstarter/models/Project.kt	85.71%	0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #2214      +/-   ##
============================================
- Coverage     68.35%   68.21%   -0.15%     
- Complexity     2198     2200       +2     
============================================
  Files           352      354       +2     
  Lines         23726    23866     +140     
  Branches       3482     3501      +19     
============================================
+ Hits          16218    16279      +61     
- Misses         5672     5746      +74     
- Partials       1836     1841       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ycheng-kickstarter · 2025-01-30T16:17:03Z

app/src/main/java/com/kickstarter/ui/compose/designsystem/KSButtons.kt

+    text: String,
+    textColor: Color = colors.textAccentGrey
+) {
+    OutlinedButton(


The Material OutlinedButton adds margins on the top and bottom by default, which made things more complicated to match with spec.

@jlplks fyi, this button I think belongs to the new Design System, move it along if needed when tackling MBL-2043

ycheng-kickstarter · 2025-01-30T16:40:00Z

app/src/main/java/com/kickstarter/ui/views/KSBottomSheetDialogFragment.kt

+    private fun close() = this.dismiss()
+
+    @Composable
+    fun KSBottomSheetDragHandle() {


Ended up drawing the drag handle myself because I don't think it was included in material 1 for bottom sheets?

ycheng-kickstarter · 2025-01-30T16:41:25Z

app/src/main/res/drawable-hdpi/rect_bottom_sheet_white_rounded.xml

-    android:right="@dimen/grid_2" />
-  <corners android:topRightRadius="@dimen/grid_2" android:topLeftRadius="@dimen/grid_2"/>
+
+  <corners android:topRightRadius="@dimen/grid_9_half" android:topLeftRadius="@dimen/grid_9_half"/>


This file wasn't being used (bc there are no other bottom sheets currently in the app) so I went ahead and increased the corner radius on it.

ycheng-kickstarter · 2025-01-30T17:00:55Z

app/src/test/java/com/kickstarter/ui/views/compose/projectpage/KSBottomSheetContentTest.kt

@@ -0,0 +1,36 @@
+package com.kickstarter.ui.views.compose.projectpage


Wanted to write a test for onclick events but didn't have a way for the stubbed viewmodel to communicate with the views inside the composeView. Let me know if you know of a way!

Take a look here might be helpful ->

android-oss/app/src/test/java/com/kickstarter/ui/activities/compose/ChangePasswordScreenTest.kt

Line 156 in b6ab5da

var acceptButtonClickedCount = 0

on the test when passwords valid and matching, accept button enabled and no warning text visible

Thanks! Just added a similar test.

…cts fixed (#2209)

* Fix typo on hyperlink * use ksString.format for the solution * fixed url

…2213)

…#2217)

Arkariang · 2025-01-30T17:51:54Z

app/src/main/java/com/kickstarter/KSApplication.java

-        Timber.w(e, "Undeliverable Exception");
-        if (e.getMessage() != null) {
-          FirebaseCrashlytics.getInstance().setCustomKey("Undeliverable Exception", e.getMessage());
+    RxJavaPlugins.setErrorHandler(t -> {


This es already in master, why are we seeing it this Pr 🤔 ?

ycheng-kickstarter added 7 commits January 23, 2025 12:35

Update graphql and data layer with projectNotice field

e6e9bb8

Functionality

18fcafe

Bottom sheet styling

7f6f9fa

Fix some padding

a96b44b

Strings not yet translated

2d0bc89

Refactor KSBottomSheetDragHandle

33e7876

Clean up

83ff445

ycheng-kickstarter added 8 commits January 29, 2025 15:02

Bottom sheet content tests

29a69ee

Fix null vs empty

b8af88b

Design QA

5b2c8a8

Remove comment

d9991d4

Clean up

a501946

Clean up

59f25c1

Remove comments

494294c

Remove comment

047a0bd

ycheng-kickstarter commented Jan 30, 2025

View reviewed changes

jlplks and others added 8 commits January 30, 2025 12:12

MBL-2000 Fix Error State for PLOT (#2208)

6900fa4

MBL-1971: Infinite loading on rewards carousel for late pledges proje…

b7bea5a

…cts fixed (#2209)

Translations of new strings (#2210)

fa34da9

Fix typo on hyperlink (#2212)

0dfe7c1

* Fix typo on hyperlink * use ksString.format for the solution * fixed url

[NO JIRA]: Release versions (#2211)

8b5cac7

Modified plotAmount and plotFirstScheduleCollection with addBoldSpan (#…

ed48cd9

…2213)

MBL-2055: Avoid adding the Authorization header if the token is empty (…

f8ca847

…#2217)

MBL-2054: Manage Exceptions from Rx streams lacking onError #2216 Open

c01a93e

Arkariang reviewed Jan 30, 2025

View reviewed changes

ycheng-kickstarter changed the base branch from master to leigh/mbl-810 January 30, 2025 17:59

ycheng-kickstarter changed the base branch from leigh/mbl-810 to master January 30, 2025 18:00

Merge branch 'master' into MBL-1974-project-notice

ea511a1

ycheng-kickstarter changed the base branch from master to leigh/mbl-810 January 30, 2025 18:54

ycheng-kickstarter changed the base branch from leigh/mbl-810 to master January 30, 2025 18:54

ycheng-kickstarter marked this pull request as ready for review January 30, 2025 18:57

ycheng-kickstarter requested review from leighdouglas, tonyteate and Arkariang January 30, 2025 19:04

ycheng-kickstarter added 2 commits February 3, 2025 11:08

Add click test

3727f75

Clean up

87ad553

ycheng-kickstarter requested a review from jlplks February 3, 2025 17:33

Arkariang approved these changes Feb 3, 2025

View reviewed changes

ycheng-kickstarter merged commit 0ae04da into master Feb 3, 2025
3 checks passed

ycheng-kickstarter deleted the MBL-1974-project-notice branch February 3, 2025 19:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MBL-1974 Project notice #2214

MBL-1974 Project notice #2214

ycheng-kickstarter commented Jan 28, 2025 •

edited

Loading

codecov-commenter commented Jan 29, 2025 •

edited

Loading

ycheng-kickstarter Jan 30, 2025

Arkariang Jan 30, 2025

ycheng-kickstarter Jan 30, 2025

ycheng-kickstarter Jan 30, 2025

ycheng-kickstarter Jan 30, 2025

Arkariang Jan 30, 2025

ycheng-kickstarter Feb 3, 2025

Arkariang Jan 30, 2025

		@@ -0,0 +1,36 @@
		package com.kickstarter.ui.views.compose.projectpage

MBL-1974 Project notice #2214

MBL-1974 Project notice #2214

Conversation

ycheng-kickstarter commented Jan 28, 2025 • edited Loading

📲 What

🤔 Why

🛠 How

👀 See

📋 QA

Story 📖

codecov-commenter commented Jan 29, 2025 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ycheng-kickstarter commented Jan 28, 2025 •

edited

Loading

codecov-commenter commented Jan 29, 2025 •

edited

Loading