Introduce fully manual pseudoclock opt (no auto advance) (#70)

When the option is set, there is no automatic advance of the internal pseudoclock. This option is intended for use in testing (avoid during debug session for the pseudoclock to diverge because of the default automatic advancements)
kiegroup · Aug 1, 2023 · e21a53d · e21a53d
1 parent 408a112
commit e21a53d
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 4 deletions.
diff --git a/...pi/src/main/java/org/drools/ansible/rulebook/integration/api/RuleConfigurationOption.java b/...pi/src/main/java/org/drools/ansible/rulebook/integration/api/RuleConfigurationOption.java
@@ -3,5 +3,12 @@
 public enum RuleConfigurationOption {
     EVENTS_PROCESSING,
     USE_PSEUDO_CLOCK,
+    /**
+     * When this option is set, there is no automatic advance of the internal pseudoclock.
+     * This option is intended for use in testing
+     * (avoid during debug session for the pseudoclock to diverge
+     * because of the default automatic advancements)
+     */
+    FULLY_MANUAL_PSEUDOCLOCK,
     ASYNC_EVALUATION
 }
diff --git a/...n-api/src/main/java/org/drools/ansible/rulebook/integration/api/RulesExecutorFactory.java b/...n-api/src/main/java/org/drools/ansible/rulebook/integration/api/RulesExecutorFactory.java
@@ -13,13 +13,16 @@
 import org.kie.api.runtime.KieSession;
 import org.kie.api.runtime.KieSessionConfiguration;
 import org.kie.api.runtime.conf.ClockTypeOption;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.atomic.AtomicLong;
 
 import static org.drools.ansible.rulebook.integration.api.RuleConfigurationOption.*;
 
 public class RulesExecutorFactory {
+    private static final Logger LOG = LoggerFactory.getLogger(RulesExecutorFactory.class);
 
     private static final AtomicLong ID_GENERATOR = new AtomicLong(1);
 
@@ -47,10 +50,14 @@ private static RulesExecutor create(RuleFormat format, RuleNotation notation, St
 
     public static RulesExecutor createRulesExecutor(RulesSet rulesSet) {
         RulesExecutor rulesExecutor = new RulesExecutor(createRulesExecutorSession(rulesSet), rulesSet.hasOption(ASYNC_EVALUATION));
-        if (rulesSet.getClockPeriod() != null) {
-            rulesExecutor.startAutomaticPseudoClock(rulesSet.getClockPeriod().getAmount(), rulesSet.getClockPeriod().getTimeUnit());
+        if (!rulesSet.hasOption(FULLY_MANUAL_PSEUDOCLOCK)) {
+            if (rulesSet.getClockPeriod() != null) {
+                rulesExecutor.startAutomaticPseudoClock(rulesSet.getClockPeriod().getAmount(), rulesSet.getClockPeriod().getTimeUnit());
+            } else {
+                rulesExecutor.startAutomaticPseudoClock(DEFAULT_AUTOMATIC_TICK_PERIOD_IN_MILLIS, TimeUnit.MILLISECONDS);
+            }
         } else {
-            rulesExecutor.startAutomaticPseudoClock(DEFAULT_AUTOMATIC_TICK_PERIOD_IN_MILLIS, TimeUnit.MILLISECONDS);
+            LOG.info("No automatic advance of internal pseudo-clock since option {} was detected", FULLY_MANUAL_PSEUDOCLOCK);
         }
         return rulesExecutor;
     }

diff --git a/...egration-api/src/test/java/org/drools/ansible/rulebook/integration/api/OnceAfterTest.java b/...egration-api/src/test/java/org/drools/ansible/rulebook/integration/api/OnceAfterTest.java
@@ -297,7 +297,7 @@ public void test57_once_after_multiple() {
                 "]\n" + //
                 "}";
 
-        RulesExecutor rulesExecutor = RulesExecutorFactory.createFromJson(RuleNotation.CoreNotation.INSTANCE.withOptions(RuleConfigurationOption.USE_PSEUDO_CLOCK), RULES);
+        RulesExecutor rulesExecutor = RulesExecutorFactory.createFromJson(RuleNotation.CoreNotation.INSTANCE.withOptions(RuleConfigurationOption.FULLY_MANUAL_PSEUDOCLOCK), RULES);
         List<Match> matchedRules;
 
         source_generic_loop57(rulesExecutor);