Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.x][DROOLS-7635] ansible-rulebook : Raise an error when a condition compares incompatible types #120

Conversation

tkobayas
Copy link
Collaborator

This is a backport PR of #114 and #117 for 1.0.x

DO-NOT-MERGE until kiegroup/drools#81 will be merged or we will decide to change the depending drools branch/version (which would require an update on this PR as well).

Until then, CI would fail with compilation errors.

…patible-type-02

[DROOLS-7635] ansible-rulebook : Raise an error when a condition compares incompatible types
kiegroup#117)

* [DROOLS-7635] ansible-rulebook : Raise an error when a condition compares incompatible types
- alpha index test, beta index test

beta index test fix

add negate test and any test

* refactor

* minor comment fix
@tkobayas tkobayas marked this pull request as ready for review October 18, 2024 05:25
@tkobayas tkobayas changed the title [DO-NOT-MERGE][1.0.x][DROOLS-7635] ansible-rulebook : Raise an error when a condition compares incompatible types [1.0.x][DROOLS-7635] ansible-rulebook : Raise an error when a condition compares incompatible types Oct 18, 2024
@tkobayas
Copy link
Collaborator Author

Now kiegroup/drools#81 has been merged, so this PR is green and ready to merge. Please review @mariofusco , thanks!

@mariofusco mariofusco merged commit 25ac2c7 into kiegroup:1.0.x Oct 18, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants