[DROOLS-7635] ansible-rulebook : Raise an error when a condition comp… #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ares incompatible types - don't miss to populate ruleSetName when runtime is used
tkobayas
force-pushed
the
DROOLS-7635-error-incompatible-type-03
branch
from
92493be
to
2d46c3a
Compare
tkobayas
commented
Oct 23, 2024
| setCondition(anisbleRule.getCondition()); | ||
| } | ||
| private void updateContextFromRule(org.drools.ansible.rulebook.integration.api.domain.Rule anisbleRule) { | ||
| setRuleSetName(anisbleRule.getRuleSetName()); |
There was a problem hiding this comment.
ruleSetName needs to be populated here. Previously, it was set in toExecModelRules, but runtime engine (AstRulesEngine, AsyncAstRulesEngine = used by drools_jpy) may call rulesSet.hasTemporalConstraint and rulesSet.hasAsyncExecution earlier and they create operator instances, so ruleSetName was null in an error log.
There are several ways to bring ruleSetName, but having rulesetName in Rule seems to be clean and easy to understand.
|
@mariofusco This is a fix for an issue I found with drools_jpy (RuleSetName is null in an error message). Please review, thanks! |
mariofusco
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ares incompatible types