Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to JDK 17 #68

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Update to JDK 17 #68

merged 2 commits into from
Aug 2, 2023

Conversation

tarilabs
Copy link
Member

@tarilabs tarilabs commented Jul 28, 2023 •
edited
Loading

This PR:

  • update project to JDK 17
  • seize a chance to use Java Text block, especially for the tests

When reviewing this PR I suggest horizontal diff 😉

Checked with Ansible SMEs on 2023-07-28:

Related PRs:

@tarilabs tarilabs mentioned this pull request Jul 28, 2023
Merged
tkobayas
tkobayas approved these changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@tkobayas tkobayas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@tarilabs tarilabs mentioned this pull request Jul 31, 2023
Merged
@tarilabs tarilabs mentioned this pull request Jul 31, 2023
Open
@tarilabs tarilabs merged commit 7149eaa into kiegroup:main Aug 2, 2023
1 check passed
@rgdoliveira rgdoliveira mentioned this pull request Aug 4, 2023
Merged
mariofusco pushed a commit that referenced this pull request Aug 21, 2023
@tarilabs @mariofusco
Update to JDK 17 (#68)
6e98c2f 
* update to JDK 17

* use Java Text block

(cherry picked from commit 7149eaa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielezonca danielezonca danielezonca approved these changes

@mariofusco mariofusco mariofusco approved these changes

@tkobayas tkobayas tkobayas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tarilabs @danielezonca @mariofusco @tkobayas