[DROOLS-7569] The pseudoClock deviates when the container is paused o… #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r process put to sleep
tkobayas
commented
Oct 2, 2023
Comment on lines
+47
to
+54
| if (diff > period * 2) { | ||
| LOG.warn("Pseudo clock is diverged, the difference is {} ms. Going to sync with the real clock.", diff); | ||
| // DROOLS-7569 : Do not rely on "catch up" mechanism of ScheduledThreadPoolExecutor.scheduleAtFixedRate(). | ||
| // This is explicit "catch up" logic. | ||
| // Also do not leap to the current time at once, because it may miss some rule firings. | ||
| for (; nextTick < System.currentTimeMillis(); nextTick += period) { | ||
| rulesEvaluator.scheduledAdvanceTimeToMills(nextTick); | ||
| } |
There was a problem hiding this comment.
Previous logic relied on "catch up" mechanism of ScheduledThreadPoolExecutor.scheduleAtFixedRate() which quickly adds a next task to the Executor when the pseudo clock is diverged. However, https://issues.redhat.com/browse/AAP-16664 tells that the mechanism doesn't work in a special occasion. Actually, such "catch up" mechanism is not stated in ScheduledThreadPoolExecutor javadoc.
So this PR does explicit "catch up" when the pseudo clock is diverged.
|
@mariofusco Feel free to share any thoughts in this PR. Thanks! |
mariofusco
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r process put to sleep