Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.67.x-blue] Fix json serialization and deserialization of decimal numbers with big scale. #3072

Open
wants to merge 9 commits into
base: 7.67.x-blue
Choose a base branch
from

Conversation

baldimir
Copy link
Member

@baldimir baldimir commented Feb 6, 2025

This resolves a problem with json serialisation and deserialisation of decimal numbers with big scale. The scale was cut, because jackson was missing configuration to handle the decimal numbers as BigDecimals.

@baldimir baldimir requested review from gitgabrio and yesamer February 6, 2025 14:24
@baldimir
Copy link
Member Author

baldimir commented Feb 6, 2025

I didn't add a test case as this is a maintenance stream and it would need a proper integration test with REST. The changes don't change any feature, just add configuration for jackson.

@baldimir
Copy link
Member Author

baldimir commented Feb 6, 2025

jenkins run cdb

@baldimir
Copy link
Member Author

baldimir commented Feb 6, 2025

jenkins run fdb

Copy link
Member

@yesamer yesamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @baldimir

@yesamer
Copy link
Member

yesamer commented Feb 6, 2025

jenkins run cdb

@baldimir
Copy link
Member Author

baldimir commented Feb 7, 2025

I restarted the checks on Jenkins directly as they are using wrong Jeknins node names. I fixed in the reruns and asked Abhishek to take a look at the CI code to fix this permanently.

@baldimir
Copy link
Member Author

baldimir commented Feb 7, 2025

There are test failures in PMML. I will fix those. Looks like test problems - tests that need to be aligned with the change (some expect Double).

@baldimir
Copy link
Member Author

baldimir commented Feb 7, 2025

jenkins run cdb

@baldimir
Copy link
Member Author

baldimir commented Feb 7, 2025

jenkins run fdb

@baldimir
Copy link
Member Author

jenkins retest this

@baldimir
Copy link
Member Author

jenkins run cdb

@baldimir
Copy link
Member Author

jenkins run fdb

@baldimir baldimir force-pushed the 7.67.x-blue-fix-decimal-numbers-scale branch from 0d46502 to aebf711 Compare February 28, 2025 12:28
@baldimir
Copy link
Member Author

jenkins run fdb

@baldimir
Copy link
Member Author

jenkins run cdb

@baldimir
Copy link
Member Author

jenkins retest this

@baldimir
Copy link
Member Author

jenkins run cdb

@baldimir
Copy link
Member Author

baldimir commented Mar 3, 2025

jenkins retest this

@baldimir
Copy link
Member Author

baldimir commented Mar 3, 2025

jenkins retest this

@baldimir
Copy link
Member Author

baldimir commented Mar 3, 2025

There are environment problems in the PR checks.

@baldimir
Copy link
Member Author

baldimir commented Mar 3, 2025

jenkins retest this

@baldimir
Copy link
Member Author

baldimir commented Mar 3, 2025

jenkins run fdb

@baldimir
Copy link
Member Author

baldimir commented Mar 4, 2025

jenkins retest this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants