-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.67.x-blue] Fix json serialization and deserialization of decimal numbers with big scale. #3072
base: 7.67.x-blue
Are you sure you want to change the base?
[7.67.x-blue] Fix json serialization and deserialization of decimal numbers with big scale. #3072
Conversation
I didn't add a test case as this is a maintenance stream and it would need a proper integration test with REST. The changes don't change any feature, just add configuration for jackson. |
jenkins run cdb |
jenkins run fdb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @baldimir
jenkins run cdb |
I restarted the checks on Jenkins directly as they are using wrong Jeknins node names. I fixed in the reruns and asked Abhishek to take a look at the CI code to fix this permanently. |
There are test failures in PMML. I will fix those. Looks like test problems - tests that need to be aligned with the change (some expect Double). |
jenkins run cdb |
jenkins run fdb |
jenkins retest this |
jenkins run cdb |
jenkins run fdb |
This reverts commit 0d46502.
This reverts commit 9836ee1ae475a6f9eb6c221e57ad7567127d8365.
This reverts commit f5fd8601b3d741d197db23d41c39c90ff6c4d973.
This reverts commit 4a62b6cf2c10fec4f10abf0c66754e3cec02c2b6.
0d46502
to
aebf711
Compare
jenkins run fdb |
jenkins run cdb |
jenkins retest this |
jenkins run cdb |
jenkins retest this |
jenkins retest this |
There are environment problems in the PR checks. |
jenkins retest this |
jenkins run fdb |
jenkins retest this |
This resolves a problem with json serialisation and deserialisation of decimal numbers with big scale. The scale was cut, because jackson was missing configuration to handle the decimal numbers as BigDecimals.