KOGITO-4344 CCE while running Monaco in dev mode #3562
Conversation
|
@karreiro Adding you as a reviewer too. This PR is supposed to fix the Monaco issue when running the webapps with The other issues (Saving on the testing webapp) are not supposed to be fixed. This PR will be merged along with the fix for that, but it's not ready yet, so this PR will have to wait until the other fix is ready too. |
|
this PR should be merged simultaneously with JSONIX fix |
There was a problem hiding this comment.
Thank you, @treblereel :-) I confirm this PR fixes the Monaco issue, but removing the flags brings the other issues back:
yes, this is another issue i am trying to fix, that isn't related to monaco ... looks like a bug in 2.9.0, i did a simple reproducer, now i am trying to find the fix/walkarounf with gwt-commitee mates |
|
this issue depends on #3570 |
|
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Thank you, @treblereel! LGTM! However, we need to merge #3582 before merging this one, otherwise, I believe it would break the build :-)
There was a problem hiding this comment.
Thank you, @treblereel.
|
No resources to review this PR. Proceed without my review. |
|
@tiagobento @karreiro @treblereel Hello, please advice how to proceed with this PR. It is approved but not merged and has conflicts. |
|
@domhanak hello, yeap, it needs to be rebased, let me do that |
JIRA: https://issues.redhat.com/browse/KOGITO-4344
Related PRs:
kiegroup/gwt-jsonix-schema-compiler#11
kiegroup/droolsjbpm-build-bootstrap#1606
#3570
#3562
#3582