Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.100.x-prod] SRVLOGIC-299 SRVLOGIC-266 SRVLOGIC-185 - Update Go Image 1.21; Bundles Update; Manager Config set #46

Merged
merged 3 commits into from
May 23, 2024

Conversation

ricardozanini
Copy link
Member

Description of the change:

Comprehends:

Motivation for the change:
Since we have now the newly Go 1.21 image officially, we can make it easier by just upgrading our base image:
https://catalog.redhat.com/software/containers/ubi8/go-toolset/5ce8713aac3db925c03774d1?architecture=amd64&image=66452129e206ab012dc21031

Additionally, I've upgraded the JDK images and set to ubi8 for ubiquiteness.

@rgdoliveira @domhanak can you please inform/confirm the image tags for these, so I can update the PR?

# The Jobs Service image to use, if empty the operator will use the default Apache Community one based on the current operator's version
jobsServicePostgreSQLImageTag: ""
jobsServiceEphemeralImageTag: ""
# The Data Index image to use, if empty the operator will use the default Apache Community one based on the current operator's version
dataIndexPostgreSQLImageTag: ""
dataIndexEphemeralTag: ""
# SonataFlow base builder image used in the internal Dockerfile to build workflow applications in preview profile
# Order of precedence is:
# 1. SonataFlowPlatform in the given namespace
# 2. This configuration
# 3. The FROM in the Dockerfile in the operator's namespace "sonataflow-operator-builder-config" configMap.
# If 1 or 2, the FROM tag will be replaced by the tag se there.
# If empty the operator will use the default Apache Community one based on the current operator's version.
sonataFlowBaseBuilderImageTag: "registry.redhat.io/openshift-serverless-1/logic-swf-builder-rhel8:1.33"
# The image to use to deploy SonataFlow workflow images in devmode profile.
# If empty the operator will use the default Apache Community one based on the current operator's version.
sonataFlowDevModeImageTag: "registry.redhat.io/openshift-serverless-1/logic-swf-devmode-rhel8:1.33"

Checklist

  • Add or Modify a unit test for your change
  • Have you verified that tall the tests are passing?
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

…ge 1.21; Bundles Update; Manager Config set

Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
Copy link
Member

@wmedvede wmedvede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added some minor comment regarding the usage of ubi8 vs ubi9 in case it could make sense.

arguments to pass to the builder\nARG MAVEN_ARGS_APPEND\n\n# Copy from build context
to skeleton resources project\nCOPY --chown=1001 . ./resources\n\nRUN /home/kogito/launch/build-app.sh
./resources\n \n#=============================\n# Runtime Run\n#=============================\nFROM
registry.access.redhat.com/ubi8/openjdk-17-runtime:latest\n\nENV LANG='en_US.UTF-8'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ricardozanini Just a reminder to double-check. In 9.99.x-pod (i.e., previous release), it looks like we used
registry.access.redhat.com/ubi9/openjdk-17:latest instead.

see:

Runtime Run\n#=============================\nFROM registry.access.redhat.com/ubi9/openjdk-17:latest\n\nENV

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

talking to my self.... after seen the image names provided by @rgdoliveira .

If produtized DI and JS images are on rhel8....
registry.redhat.io/openshift-serverless-1/logic-jobs-service-postgresql-rhel8:1.33.0

maybe ubi8 is the correct choice here.
Anyway, just forget my comment if don't make sense.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was ubi9, but yeah I'm downgrading to align and avoid problems.

@@ -16,7 +16,7 @@ RUN /home/kogito/launch/build-app.sh ./resources
#=============================
# Runtime Run
#=============================
FROM registry.access.redhat.com/ubi9/openjdk-17:latest
FROM registry.access.redhat.com/ubi9/openjdk-17-runtime:latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regarding my previous comment, here we have ubi9

Copy link
Member Author

@ricardozanini ricardozanini May 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine this one is upstream.

@@ -16,7 +16,7 @@ RUN /home/kogito/launch/build-app.sh ./resources
#=============================
# Runtime Run
#=============================
FROM registry.access.redhat.com/ubi9/openjdk-17:latest
FROM registry.access.redhat.com/ubi8/openjdk-17-runtime:latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ubi8 here, IDK, just a reminder

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is midstream.

@@ -15,7 +15,7 @@
- schema_version: 1
name: "operator-builder"
version: "1.33.0"
from: "registry.access.redhat.com/ubi8/go-toolset:1.20.12"
from: "registry.access.redhat.com/ubi8/go-toolset:1.21"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, ubi8.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's midstream.

Copy link
Member

@rgdoliveira rgdoliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ricardozanini I've suggested the correct prod images tags.

@rgdoliveira
Copy link
Member

Also something that is missing for the bundle is the annotations for infra feature tests, same thing you did for OSL 1.32 in Jira SRVLOGIC-245, can you please also add that in this PR?

@rgdoliveira rgdoliveira merged commit 5225762 into kiegroup:9.100.x-prod May 23, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants