Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition in e2e login test #1012

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

marlonbaeten
Copy link
Contributor

Possible solution for #991

The login form navigates to the setup page by default, where the success message appears. We now wait for this navigation to happen.

Copy link

github-actions bot commented Feb 10, 2025

Sigrid maintainability feedback

💭️ You did not change any files that are measured by Sigrid


View this system in Sigrid

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.76%. Comparing base (18917fc) to head (c2a678f).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1012   +/-   ##
=======================================
  Coverage   89.76%   89.76%           
=======================================
  Files         248      248           
  Lines       12987    12987           
  Branches     1318     1318           
=======================================
  Hits        11658    11658           
  Misses       1235     1235           
  Partials       94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants