Added analog clipepr module #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killbizz
reviewed
Sep 26, 2022
| Rin = 1e3; //1kOhm | ||
| C = 100e-9; //100nF | ||
|
|
||
| h = 1e-5; |
There was a problem hiding this comment.
Check if the h variable is a constant or changes according to sampleRate/T parameters
killbizz
reviewed
Sep 26, 2022
| return vDiodes; | ||
| } | ||
|
|
||
| float Clipper::fixedPoint(float vIn) |
There was a problem hiding this comment.
Update the name to clarify the code behaviour
killbizz
reviewed
Sep 26, 2022
|
|
||
| float Clipper::capacitorVoltage(float vIn) | ||
| { | ||
| if(inputGain < 1.0f) |
There was a problem hiding this comment.
Check if this IF is needed to make the code work
killbizz
requested changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ciao Gabri, come promesso ecco il clipper analogico ;) dimmi se va bene