Rollup of outstanding PRs #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to the current toml crate. I was trying to resolve build issues on rustc 1.18.0-nightly. This wasn't the culprit but it's good to stay current for 0.x dependencies.
…rges Rebase on top of Matthew's Option<fn(..)> changes. Hopefully resolves the build issue with 1.18.0-nightly.
… merges Rebase on top of more recent changes; this just bumps the clap dep now.
|
LGTM |
|
This wasn't included in the PR. |
Oops, you're right. I was going to include it, but then held off because it's a breaking change. But the |
kinetiknz
pushed a commit
that referenced
this pull request
Apr 11, 2017
Change package name to moz-cheddar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's all the outstanding pull requests from the upstream repository. Not the ideal rebase order, but at least it brings things up to date a bit.
Doesn't address the build failure on 1.18.0-nightly. I suspect we need another
syntexbump to get a compatibleserde_derive.