-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.1.3 #39
Merged
Merged
Release 0.1.3 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we will now reconcile PackageVersions when we want to know about the versions of a package, and PackageVersions::VersionLeaf is similar to Project::Leaf in the existing controller pair. Let's also finish implementation of Conditions here (in the following commits) Signed-off-by: Kingdon Barrett <[email protected]>
Signed-off-by: Kingdon Barrett <[email protected]>
we can probably do this without a VersionLeaf Signed-off-by: Kingdon Barrett <[email protected]>
the default ImagePullPolicy is IfNotPresent Signed-off-by: Kingdon Barrett <[email protected]>
we only need one reconciler because there is only one layer deep (there's no need to fetch multiple pages for each package, and we already know which packages we want to monitor versions for, so there's no need to rewrite GithubOrg or "Project" because there is no second fetch.) This also means we're not writing a second Wasm, lol Signed-off-by: Kingdon Barrett <[email protected]>
these are the seed records (this is not a real controller either) Signed-off-by: Kingdon Barrett <[email protected]>
Signed-off-by: Kingdon Barrett <[email protected]>
rails generate model Version package:references version:string download_count:integer rails generate model VersionMeasurement package:references version:references count:integer measured_at:datetime Signed-off-by: Kingdon Barrett <[email protected]>
Signed-off-by: Kingdon Barrett <[email protected]>
Signed-off-by: Kingdon Barrett <[email protected]>
Signed-off-by: Kingdon Barrett <[email protected]>
Signed-off-by: Kingdon Barrett <[email protected]>
Signed-off-by: Kingdon Barrett <[email protected]>
Signed-off-by: Kingdon Barrett <[email protected]>
I also haven't bumped the minor because I want Release 0.2.0 to include: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release introduces Version and VersionMeasurement
I've deferred the minor version bump until after we've verified this works in the dev environment, however it isn't possible to change the dev environment without releasing another version the way I've set this up
It isn't really great, but it's easy enough to roll out another version if this one breaks 🤞