Fixes for numpy 2.0 #1090
Merged
Fixes for numpy 2.0 #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes sure that test suite runs (without the parts that depend on meshio and matplotlib which both are currently broken with numpy==2) with numpy==2 nightly build.
Note that meshio does not currently work with numpy==2 because of removed functionality. Because meshio is an optional dependency of scikit-fem, I don't currently plan to enforce numpy<2 here. Even though meshio is inactive, fix to meshio is quite easy (replacing some np.string_ with np.bytes_) so perhaps it will happen.
It is still possible that some code breaks because we do not guard against stuff like np.uint64 going into np.isin and other functions used within scikit-fem that will be, for some reason, more stricter of their type in numpy==2. It is not entirely clear to me what change in numpy==2 causes this, and it might even be a bug because I am testing against a nightly build.