Improve post mgmt #372
Merged
Improve post mgmt #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SepsiLaszlo
force-pushed
the
improve-post-mgmt
branch
from
66f36f9
to
707fc93
Compare
Co-Authored-By: Sámuel Fekete <[email protected]> Co-Authored-By: DannySS123 <[email protected]> Co-Authored-By: Beni <[email protected]> Co-Authored-By: Bálint Berente <[email protected]>
SepsiLaszlo
force-pushed
the
improve-post-mgmt
branch
from
707fc93
to
bab9455
Compare
OmTheTurtle
reviewed
Nov 28, 2021
app/controllers/posts_controller.rb
Outdated
Comment on lines
14
to
15
| @group_post_types = {} | ||
| @group.post_types.each { |post_type| @group_post_types[post_type.id] = post_type } |
There was a problem hiding this comment.
I think this could be a reduce
OmTheTurtle
reviewed
Nov 28, 2021
app/controllers/posts_controller.rb
Outdated
Comment on lines
12
to
13
| @post_type_ids = @group.post_types.map(&:id) | ||
| @post_type_ids.delete(PostType::LEADER_POST_ID) |
There was a problem hiding this comment.
Maybe we can express this as a select after the map to avoid mutations.
OmTheTurtle
reviewed
Nov 28, 2021
app/controllers/posts_controller.rb
Outdated
Comment on lines
16
to
17
| @memberships = @group.memberships.active.includes(:posts, :user) | ||
| @memberships = @memberships.sort { |a, b| hu_compare(a.user.full_name, b.user.full_name) } |
There was a problem hiding this comment.
can the sort be chained after the previous call?
Tschonti
reviewed
Nov 28, 2021
Signed-off-by: SepsiLaszlo <[email protected]> fix Signed-off-by: SepsiLaszlo <[email protected]>
Signed-off-by: SepsiLaszlo <[email protected]>
SepsiLaszlo
force-pushed
the
improve-post-mgmt
branch
from
463ab2c
to
79eee2a
Compare
|
@OmTheTurtle Thank you for the multiple greate comments on this PR! 🎆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new?
We implemented a new post management system to enable group leaders and evaluation helpers to update multiple posts at one page.
Click on the new
Posztok kezelésebutton on your group's page.This will open the post management page, where all meberships and posts are listed in a table view.
Just click on the post in the row of the selected user to perform the action indicated between the parentheses.
We hope this makes administrating posts faster!
Todos: