add register.js to sideEffects #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrapperup
force-pushed
the
fix-side-effects
branch
from
3a2eab4 to
cfcfa21
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #118 +/- ##
=======================================
Coverage 98.74% 98.74%
=======================================
Files 4 4
Lines 1032 1032
=======================================
Hits 1019 1019
Misses 13 13 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When bundling and using the
@kitajs/html/registermodule, it is removed during tree shaking. This affects Vite and esbuild (and maybe others, haven't tested), which would cause the following error to happen at runtime:Adding
register.jsas a side effect will prevent bundlers from removing the module entirely when used, since it isn't a pure module.Fixes #89 as well.