Remove unneccessary null-checks #5631
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that 'settings' can never be null, as other parts of the code rely on it not being null, without checking for it. The commit doesn’t touch public boolean isRequired() as it is handled in a different PR already.
IkramMaalej
reviewed
May 23, 2023
There was a problem hiding this comment.
I think that this check is still needed because a NPE still occurs when trying to import some data using a mapping file that creates metadata groups and metadata entries within the group that are both unknown to the ruleset . See #5603 #5217 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that 'settings' can never be null, as other parts of the code rely on it not being null, without checking for it. The commit doesn’t touch
public boolean isRequired()as it is already handled in PR #5609.