Drag & drop multiple tree nodes in structure tree #6340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| Set<String> logicalRowKeys = getTreeNodeRowKeys(this.getSelectedLogicalNodes()); | ||
|
|
||
| String physicalRowKey = null; |
Check notice
Code scanning / CodeQL
Unread local variable Note
No, judging by the current set of changes in this pull request I think it is no problem to merge it before the PrimeFaces update. I am surprised that multi select in the structre tree can be implemented with our current PrimeFaces version 8, though. I thought there was a bug in PrimeFaces 8 with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5926
This is a very early version of supporting drag & drop of multiple tree node elements in the structure tree.
Todo
@solth Let me know if you think this conflicts too much with your current development plans (PrimeFaces update) or whether this could be merged sooner.