-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service-based remote shell #3
base: master
Are you sure you want to change the base?
Conversation
I'm hesitating about that one. Why the I really love the separation, but this will broke many things :/ |
No ok, It's Could you improve your PR in order to add an UI choice: run as a service or as a standalone application ? And then, listen on SSH and choice either the previous way to work, or yours: it will allows to test android API either within the app, or within a service. That's would be awesome! |
So I can replace Will do the UI change. I dont know when :) or if it will be as visually nice as now, but will do. Thanks for the feedback and the tests. |
I made some progress on this, using a ToggleButton for service-based. Problem is that I found no way to stop the running listenTCP on the Activity version. I am considering to have a splash question to the user. This or start as the Service-version, and have a single-use button to switch to the Activity version. What would be better? Start with service-based, or ask on every start? |
@tito, I finally managed to work around Twisted Reactor integration, but now this needs a patched Kivy (kivy/kivy#1805), otherwise I have troubles with both reactors (Activity and Service) trying to bind the same port, without waiting the other one to stop listening. Can you please take a look at kivy/kivy#1805 ? |
The merge of kivy/kivy#1805 closed this one by accident. Is there a way to reopen? |
@alanjds sry, this got ignored, could you rebase to master, would be a welcome addition. |
Got it. I do not know when, but will rebase the thing. Thanks. |
@alanjds Waiting keenly 😺 |
Oops. Forgot completely. Thanks for the nudge. |
Bump! |
Conflicts: main.py
Conflicts: main.py
Conflicts: main.py
Conflicts: main.py
Conflicts: main.py
Conflicts: main.py
I updated the branch with a rebased version to keep the PR. Please "force" the pull if needed. The old branch was renamed to But it had not worked here on MacOSX. Seems to be about the upstream changes to the UI. Attached is the the console output.
|
This version starts a service-based remote shell.
It does not drop the connection nor freeze on Home button pressed, but have no access to the mActivity:
Do you think it is worth the benefit?