Fix whitelabeling support #4573
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook staging is available at https://kiwicom-orbit-dsil-fix-whitelabeling-support.surge.sh |
|
Size Change: +49 B (+0.01%) Total Size: 459 kB
ℹ️ View Unchanged
|
Deploying orbit with
|
| Latest commit: |
beef768
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4aa7c2db.orbit.pages.dev |
| Branch Preview URL: | https://dsil-fix-whitelabeling-suppo.orbit.pages.dev |
DSil
force-pushed
the
dsil/fix-whitelabeling-support
branch
from
139c7ca to
bd6d5ba
Compare
| "button-primary-subtle-foreground": `var(--button-primary-subtle-foreground, ${tokens.buttonPrimarySubtleForeground})`, | ||
| "button-primary-subtle-foreground-hover": `var(--button-primary-subtle-foreground-hover, ${tokens.buttonPrimarySubtleForegroundHover})`, | ||
| "button-primary-subtle-foreground-active": `var(--button-primary-subtle-foreground-active, ${tokens.buttonPrimarySubtleForegroundActive})`, | ||
| "button-primary-foreground": `rgba(var(--button-primary-foreground, ${tokens.buttonPrimaryForeground}), <alpha-value>)`, |
There was a problem hiding this comment.
How does the <alpha-value> work here? 🤔
There was a problem hiding this comment.
Honestly, it's a bit of tailwind magic that seems undocumented buy widely used by the community 😬 I also believe it will change with Tailwind v4, but that is a matter for another time
| Object.keys(theme).reduce((acc, key) => { | ||
| if (key.startsWith("palette")) { | ||
| if (key.startsWith("palette") || key.startsWith("buttonPrimary") || key === "borderRadius100") { |
There was a problem hiding this comment.
Is this because all the eligible tokens to be overridden start with these prefixes?
There was a problem hiding this comment.
For now, yes. I just wanted to make it work. If we ever consider expanding the list we can think of a more elegant solution
CSS vars were not being injected in the test environment
Small test adjustments from the CSS vars changes
DSil
force-pushed
the
dsil/fix-whitelabeling-support
branch
from
bd6d5ba to
beef768
Compare
mvidalgarcia
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tokens were configurable for whitelabels but were not being converted in CSS Vars, so they were really no themeable.
Also, the playwright wrapper was not having access to any of the CSS Vars. This is now fixed.
Closes FEPLT-2197
✨
Description by Callstackai
This PR fixes whitelabeling support by ensuring that certain tokens are converted into CSS variables, making them themeable. It also resolves issues with the Playwright wrapper's access to CSS variables.
Diagrams of code changes
sequenceDiagram participant App participant OrbitProvider participant TokensToCssVars participant Document App->>OrbitProvider: Initialize with defaultTheme OrbitProvider->>OrbitProvider: getCssVarsForWL(defaultTheme.orbit) Note over OrbitProvider: Process palette, buttonPrimary,<br/>and borderRadius100 tokens OrbitProvider->>TokensToCssVars: tokensToCssVars(tokens) TokensToCssVars->>TokensToCssVars: Convert tokens to CSS vars TokensToCssVars-->>Document: Create and append<br/>style element with CSS vars Note over Document: CSS vars available as<br/>:root custom properties Document-->>App: Apply themed styles<br/>using CSS varsFiles Changed
getCssVarsForWLfunction to include additional tokens for whitelabeling.kebabCasefunction to handle uppercase letters and numbers.generateRgbafunction for use in other modules.generateRgbafunction.This PR includes files in programming languages that we currently do not support. We have not reviewed files with the extensions
.snap. See list of supported languages.