-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix Alert story #4581
Open
domihustinova
wants to merge
1
commit into
master
Choose a base branch
from
domi/update-story
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore: fix Alert story #4581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Storybook staging is available at https://kiwicom-orbit-domi-update-story.surge.sh |
Size Change: -2 B (0%) Total Size: 459 kB
ℹ️ View Unchanged
|
Deploying orbit with Cloudflare Pages
|
sarkaaa
reviewed
Jan 16, 2025
domihustinova
force-pushed
the
domi/update-story
branch
from
January 16, 2025 16:48
01d8684
to
7ac3915
Compare
domihustinova
force-pushed
the
domi/update-story
branch
from
January 16, 2025 17:01
7ac3915
to
24530a3
Compare
LGTM. |
sarkaaa
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced
message
arg withchildren
arg following the pattern from other stories. Also removedbutton
arg and hardcodedinlineActions
.✨
Description by Callstackai
This PR updates the Alert story by replacing the
message
argument withchildren
, removing thebutton
argument, and hardcodinginlineActions
. It also adjusts the controls in the story parameters accordingly.Diagrams of code changes
Files Changed
children
instead ofmessage
and removed unusedbutton
argument.