-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Modal): ensure Modal has rounded bottom corners on larger viewports #4582
Open
RobinCsl
wants to merge
2
commits into
master
Choose a base branch
from
rcsl/add-missing-padding-for-modal-with-header-only
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(Modal): ensure Modal has rounded bottom corners on larger viewports #4582
RobinCsl
wants to merge
2
commits into
master
from
rcsl/add-missing-padding-for-modal-with-header-only
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Storybook staging is available at https://kiwicom-orbit-rcsl-add-missing-padding-for-modal-with-header-only.surge.sh |
Size Change: +10 B (0%) Total Size: 459 kB
ℹ️ View Unchanged
|
RobinCsl
force-pushed
the
rcsl/add-missing-padding-for-modal-with-header-only
branch
from
January 17, 2025 12:29
b7fc74b
to
6108114
Compare
Deploying orbit with Cloudflare Pages
|
RobinCsl
force-pushed
the
rcsl/add-missing-padding-for-modal-with-header-only
branch
from
January 17, 2025 16:06
6108114
to
ef00bba
Compare
RobinCsl
force-pushed
the
rcsl/add-missing-padding-for-modal-with-header-only
branch
from
January 17, 2025 16:27
f594aec
to
2b26ce7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes FEPLT-2208
This Pull Request meets the following criteria:
For new components:
d.ts
files and are exported inindex.d.ts
✨
Description by Callstackai
This PR adds a new modal variant with a header only and includes visual regression tests for it.
Diagrams of code changes
Files Changed