Fix playroom deployment #4605
Merged
Fix playroom deployment #4605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid building and deploying on dry-run Get correct version tag for URL construction
|
Storybook staging is available at https://kiwicom-orbit-dsil-fix-playroom-deployment.surge.sh Playroom staging is available at https://kiwicom-orbit-dsil-fix-playroom-deployment.surge.sh/playroom |
|
Size Change: -3 B (0%) Total Size: 459 kB
ℹ️ View Unchanged
|
Deploying orbit with
|
| Latest commit: |
98f121a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6a3e5a16.orbit.pages.dev |
| Branch Preview URL: | https://dsil-fix-playroom-deployment-ecyv.orbit.pages.dev |
Comment on lines
76
to
+92
| - name: Build Playroom | ||
| if: ${{ github.event.inputs.dryrun == 'false' }} | ||
| run: yarn components build:playroom | ||
|
|
||
| - name: Build Storybook | ||
| if: ${{ github.event.inputs.dryrun == 'false' }} | ||
| run: yarn components build:storybook | ||
|
|
||
| - name: Get tag version | ||
| if: ${{ github.event.inputs.dryrun == 'false' }} | ||
| run: | | ||
| git fetch --tags --quiet | ||
| echo "VERSION_TAG=$(git tag --list '@kiwicom/orbit-components@*' --sort=creatordate | sed '$!d' | sed -n '$ s|.*@||; s/\./-/gp')" >> $GITHUB_ENV | ||
|
|
||
| - name: Get Storybook domain | ||
| run: | | ||
| echo "DOMAIN=https://kiwicom-orbit-v${VERSION_TAG}.surge.sh" >> $GITHUB_ENV | ||
| yarn components deploy:surge ${DOMAIN} --token ${{ secrets.SURGE_TOKEN }} | ||
| - name: Publish Storybook and Playroom | ||
| if: ${{ github.event.inputs.dryrun == 'false' }} | ||
| run: yarn components deploy:surge https://kiwicom-orbit-v${VERSION_TAG}.surge.sh --token ${{ secrets.SURGE_TOKEN }} |
There was a problem hiding this comment.
I'm thinking that we might want to merge all these steps into one. I'm not sure if there are advantages to keeping them split.
There was a problem hiding this comment.
That is a good point. I would prefer to touch the minimum now until we got this finally working. It has been two releases already with failed deployments 😞
mvidalgarcia
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses 3 issues:
FEPLT-2238
✨
Description by Callstackai
This PR fixes issues related to the deployment of Playroom, including preventing deployment during dry runs, correcting the URL generation for Playroom, and ensuring the correct link is published in Slack.
Diagrams of code changes
sequenceDiagram participant GH as GitHub Workflow participant Build as Build Process participant Surge as Surge.sh participant PR as Pull Request Note over GH: Workflow starts alt dryrun is false GH->>Build: Build Playroom GH->>Build: Build Storybook GH->>GH: Get version tag GH->>Surge: Publish to kiwicom-orbit-v{VERSION}.surge.sh GH->>PR: Post changelog with Playroom link end Note over GH: Workflow endsFiles Changed
This PR includes files in programming languages that we currently do not support. We have not reviewed files with the extensions
.yml,.mjs. See list of supported languages.