Make kiwix::Server a simple wrapper around kiwix::InternalServer.

`kiwix::Server` is now a simple exposition of a public API on top of the
private `InternalServer`.

include/server.h

@@ -105,7 +105,6 @@ namespace kiwix
         * @param library The library to serve.
         */
        Server(const ServerConfiguration& configuration);
-
        virtual ~Server();
 
        /**
@@ -123,11 +122,17 @@ namespace kiwix
         */
        bool isRunning();
 
+       /**
+        * Get the port of the server
+        */
        int getPort();
+
+       /**
+        * Get the ipAddress of the server
+        */
        std::string getAddress();
 
      protected:
-       ServerConfiguration m_configuration;
        std::unique_ptr<InternalServer> mp_server;
   };
 }

src/server.cpp

@@ -42,29 +42,21 @@ ServerConfiguration& ServerConfiguration::setRoot(const std::string& root)
 }
 
 Server::Server(const ServerConfiguration& configuration) :
-  m_configuration(configuration),
-  mp_server(nullptr)
+  mp_server(new InternalServer(configuration))
 {
 }
 
 Server::~Server() = default;
 
 bool Server::start() {
-  mp_server.reset(new InternalServer(m_configuration));
   return mp_server->start();
 }
 
 void Server::stop() {
-  if (mp_server) {
-    mp_server->stop();
-    mp_server.reset(nullptr);
-  }
+  mp_server->stop();
 }
 
 bool Server::isRunning() {
-  if (!mp_server) {
-    return false;
-  }
   return mp_server->isRunning();
 }