Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support any attribute OID in DName #212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lionello
Copy link
Contributor

This patch allows one to add any OID name-value pair in a DName structure.

@Ruffio
Copy link

Ruffio commented Jul 25, 2017

@lionello What is the issue with the current implementation of OID in DName?

@lionello
Copy link
Contributor Author

@Ruffio The old implementation would throw an exception when an 'unknown' OID was encountered in the DName, 'unknown' meaning an OID that wasn't explicitly hardcoded in jsrsasign. With this patch, unknown OIDs are not converted to strings and simply output as numbers.

@Ruffio
Copy link

Ruffio commented Jul 25, 2017

@lionello Are you missing specific OIDs? Which? I see your point, but I don't know if @kjur wants to open up for this. @kjur ?

@lionello
Copy link
Contributor Author

It's impossible to add "all" OIDs, since new ones can be created at any time. The library should provide a way to obtain unknown OIDs (these are not invalid, so an exception seems misplaced.)

@Ruffio
Copy link

Ruffio commented Jul 25, 2017

@lionello I see and agree with you. @kjur What do you say?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants