Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: make CharRefTokenizer non-copyable #107

Merged
merged 1 commit into from
Sep 8, 2024
Merged

Conversation

kkebo
Copy link
Owner

@kkebo kkebo commented Aug 13, 2024

No description provided.

@kkebo kkebo self-assigned this Aug 13, 2024

This comment has been minimized.

@kkebo kkebo force-pushed the noncopyable-charreftokenizer branch from 746b375 to 8a84bc4 Compare August 13, 2024 08:49

This comment has been minimized.

@kkebo kkebo force-pushed the noncopyable-charreftokenizer branch from 8a84bc4 to 2037774 Compare August 20, 2024 17:27

This comment has been minimized.

@kkebo kkebo force-pushed the noncopyable-charreftokenizer branch from 2037774 to 6251421 Compare September 8, 2024 07:30

This comment has been minimized.

@kkebo kkebo force-pushed the noncopyable-charreftokenizer branch from 6251421 to edbfd13 Compare September 8, 2024 07:41

This comment has been minimized.

@kkebo kkebo force-pushed the noncopyable-charreftokenizer branch from edbfd13 to 6f2aab5 Compare September 8, 2024 08:18

This comment has been minimized.

@kkebo kkebo force-pushed the noncopyable-charreftokenizer branch from 6f2aab5 to d66038b Compare September 8, 2024 09:09
Copy link
Contributor

github-actions bot commented Sep 8, 2024

Code Metrics Report

main (c968f88) #107 (d124cbd) +/-
Coverage 85.7% 85.6% -0.1%
Details
  |           | main (c968f88) | #107 (d124cbd) |  +/-  |
  |-----------|----------------|----------------|-------|
- | Coverage  |          85.7% |          85.6% | -0.1% |
  |   Files   |              9 |             10 |    +1 |
  |   Lines   |           1586 |           1584 |    -2 |
- |   Covered |           1360 |           1357 |    -3 |

Code coverage of files in pull request scope (85.6% → 85.5%)

Files Coverage +/-
Sources/Tokenizer/CharRefTokenizer.swift 98.1% 0.0%
Sources/Tokenizer/Optional+take.swift 100.0% +100.0%
Sources/Tokenizer/Tokenizer.swift 83.3% -0.2%

Reported by octocov

@kkebo
Copy link
Owner Author

kkebo commented Sep 8, 2024

Comparing results between 'main' and 'Current_run'

Host 'Raspberry-beetle' with 4 'aarch64' processors with 7 GB memory, running:
#1 SMP PREEMPT Debian 1:6.6.47-1+rpt1 (2024-09-02)

MyBenchmark

lipsum metrics

Time (wall clock): results within specified thresholds, fold down for details.

Time (wall clock) (μs) * p0 p25 p50 p75 p90 p99 p100 Samples
main 24 24 24 24 24 25 25 100
Current_run 23 23 23 23 24 24 24 100
� -1 -1 -1 -1 0 -1 -1 0
Improvement % 4 4 4 4 0 4 4 0

lipsum-zh metrics

Time (wall clock): results within specified thresholds, fold down for details.

Time (wall clock) (ns) * p0 p25 p50 p75 p90 p99 p100 Samples
main 3010 3017 3023 3033 3039 3142 3144 100
Current_run 3106 3117 3123 3125 3133 3160 3173 100
� 96 100 100 92 94 18 29 0
Improvement % -3 -3 -3 -3 -3 -1 -1 0

medium-fragment metrics

Time (wall clock): results within specified thresholds, fold down for details.

Time (wall clock) (μs) * p0 p25 p50 p75 p90 p99 p100 Samples
main 71 71 71 71 71 72 72 100
Current_run 68 68 68 68 68 68 69 100
� -3 -3 -3 -3 -3 -4 -3 0
Improvement % 4 4 4 4 4 6 4 0

small-fragment metrics

Time (wall clock): results within specified thresholds, fold down for details.

Time (wall clock) (ns) * p0 p25 p50 p75 p90 p99 p100 Samples
main 7374 7414 7422 7434 7438 7475 7748 100
Current_run 7423 7459 7496 7516 7528 7614 7969 100
� 49 45 74 82 90 139 221 0
Improvement % -1 -1 -1 -1 -1 -2 -3 0

strong metrics

Time (wall clock): results within specified thresholds, fold down for details.

Time (wall clock) (μs) * p0 p25 p50 p75 p90 p99 p100 Samples
main 35 35 35 35 35 35 35 100
Current_run 35 35 35 35 35 35 35 100
� 0 0 0 0 0 0 0 0
Improvement % 0 0 0 0 0 0 0 0

tiny-fragment metrics

Time (wall clock): results within specified thresholds, fold down for details.

Time (wall clock) (ns) * p0 p25 p50 p75 p90 p99 p100 Samples
main 710 711 712 713 715 728 736 100
Current_run 761 764 765 769 771 777 778 100
� 51 53 53 56 56 49 42 0
Improvement % -7 -7 -7 -8 -8 -7 -6 0

@kkebo kkebo merged commit a656fc0 into main Sep 8, 2024
2 checks passed
@kkebo kkebo deleted the noncopyable-charreftokenizer branch September 8, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant