Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace String with Str #78

Merged
merged 1 commit into from
Jul 27, 2024
Merged

refactor: replace String with Str #78

merged 1 commit into from
Jul 27, 2024

Conversation

kkebo
Copy link
Owner

@kkebo kkebo commented May 20, 2024

Comparing results between 'main' and 'Current_run'

Host 'Brown-rhinoceros-beetle' with 8 'aarch64' processors with 7 GB memory, running:                                                                                                                                
#1 SMP PREEMPT_DYNAMIC Sat Jul 13 23:35:21 UTC 2024                                                                                                                                                                  

MyBenchmark

lipsum metrics

Time (wall clock): results within specified thresholds, fold down for details.

Time (wall clock) (μs) * p0 p25 p50 p75 p90 p99 p100 Samples
main 16 16 16 16 16 17 17 100
Current_run 16 16 16 16 17 17 17 100
Δ 0 0 0 0 1 0 0 0
Improvement % 0 0 0 0 -6 0 0 0

lipsum-zh metrics

Time (wall clock): results within specified thresholds, fold down for details.

Time (wall clock) (ns) * p0 p25 p50 p75 p90 p99 p100 Samples
main 1550 1552 1559 1564 1607 1664 1666 100
Current_run 1552 1558 1563 1569 1616 1631 1683 100
Δ 2 6 4 5 9 -33 17 0
Improvement % 0 0 0 0 -1 2 -1 0

medium-fragment metrics

Time (wall clock): results within specified thresholds, fold down for details.

Time (wall clock) (μs) * p0 p25 p50 p75 p90 p99 p100 Samples
main 44 44 44 44 44 47 47 100
Current_run 44 44 44 45 45 47 48 100
Δ 0 0 0 1 1 0 1 0
Improvement % 0 0 0 -2 -2 0 -2 0

small-fragment metrics

Time (wall clock): results within specified thresholds, fold down for details.

Time (wall clock) (ns) * p0 p25 p50 p75 p90 p99 p100 Samples
main 4543 4555 4563 4710 4887 4899 4907 100
Current_run 4617 4628 4637 4788 4792 4841 4954 100
Δ 74 73 74 78 -95 -58 47 0
Improvement % -2 -2 -2 -2 2 1 -1 0

strong metrics

Time (wall clock): results within specified thresholds, fold down for details.

Time (wall clock) (μs) * p0 p25 p50 p75 p90 p99 p100 Samples
main 21 21 21 21 21 22 22 100
Current_run 21 21 21 21 21 22 22 100
Δ 0 0 0 0 0 0 0 0
Improvement % 0 0 0 0 0 0 0 0

tiny-fragment metrics

Time (wall clock): results within specified thresholds, fold down for details.

Time (wall clock) (ns) * p0 p25 p50 p75 p90 p99 p100 Samples
main 459 533 616 758 930 947 961 100
Current_run 501 578 687 815 930 935 944 100
Δ 42 45 71 57 0 -12 -17 0
Improvement % -9 -8 -12 -8 0 1 2 0

@kkebo kkebo self-assigned this May 20, 2024

This comment has been minimized.

@kkebo kkebo marked this pull request as ready for review May 28, 2024 17:05

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@kkebo kkebo force-pushed the replace-string-with-str branch 2 times, most recently from 94de8e2 to f44c662 Compare July 25, 2024 18:00

This comment has been minimized.

Copy link
Contributor

Code Metrics Report

main (8c9f3cf) #78 (e14a299) +/-
Coverage 85.1% 85.2% +0.1%
Details
  |           | main (8c9f3cf) | #78 (e14a299) |  +/-  |
  |-----------|----------------|---------------|-------|
+ | Coverage  |          85.1% |         85.2% | +0.1% |
  |   Files   |              9 |             9 |     0 |
  |   Lines   |           1613 |          1600 |   -13 |
- |   Covered |           1373 |          1364 |    -9 |

Code coverage of files in pull request scope (82.6% → 82.8%)

Files Coverage +/-
Sources/Tokenizer/Tokenizer.swift 82.8% +0.1%

Reported by octocov

@kkebo kkebo merged commit f1a8cbd into main Jul 27, 2024
2 checks passed
@kkebo kkebo deleted the replace-string-with-str branch July 27, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant