Update watchers.py #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added min and max to have the number selected only between 1 and 10
Updated placeholder to limit within input width
|
You'd need to update the relevant test though.. |
kkinder
requested changes
Aug 10, 2024
|
Sure, thanks for letting me know. |
Updated the test case string From `Enter the guess` to `Guess`
|
Hi @kkinder , Updated tests. Hope its fine |
|
Hi @kkinder , Should the documentation also needs corresponding update? |
kishankarun
commented
Aug 15, 2024
kishankarun
added a commit
to kishankarun/puepy-mkdocs
that referenced
this pull request
Aug 15, 2024
Updated the new changes as per 05-watchers changes based on pull request kkinder/puepy#47
|
Seems reasonable. |
kkinder
approved these changes
Aug 17, 2024
|
@kkinder I have updated the documentation also |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added min and max to have the number selected only between 1 and 10