Logging improvements when failing to parse JSON/XML/ION. Do not inclu…

…de the stack trace since it doesn't provide any value with these exceptions which are expected when the JSON is invalid. Log the input string rather than the Event which was not readable. (opensearch-project#4839)

Signed-off-by: David Venable <[email protected]>

data-prepper-plugins/parse-json-processor/build.gradle

@@ -16,6 +16,7 @@ dependencies {
     implementation libs.parquet.common
     testImplementation project(':data-prepper-test-common')
     testImplementation project(':data-prepper-test-event')
+    testImplementation testLibs.slf4j.simple
 }
 
 test {

data-prepper-plugins/parse-json-processor/src/main/java/org/opensearch/dataprepper/plugins/processor/parse/ion/ParseIonProcessor.java

@@ -21,7 +21,7 @@
 import java.util.HashMap;
 import java.util.Optional;
 
-import static org.opensearch.dataprepper.logging.DataPrepperMarkers.EVENT;
+import static org.opensearch.dataprepper.logging.DataPrepperMarkers.SENSITIVE;
 
 @DataPrepperPlugin(name = "parse_ion", pluginType = Processor.class, pluginConfigurationType = ParseIonProcessorConfig.class)
 public class ParseIonProcessor extends AbstractParseProcessor {
@@ -45,10 +45,10 @@ protected Optional<HashMap<String, Object>> readValue(String message, Event cont
             // We need to do a two-step process here, read the value in, then convert away any Ion types like Timestamp
             return Optional.of(objectMapper.convertValue(objectMapper.readValue(message, new TypeReference<>() {}), new TypeReference<>() {}));
         } catch (JsonProcessingException e) {
-            LOG.error(EVENT, "An exception occurred due to invalid Ion while reading event [{}]", context, e);
+            LOG.error(SENSITIVE, "An exception occurred due to invalid Ion while parsing [{}] due to {}", message, e.getMessage());
             return Optional.empty();
         } catch (Exception e) {
-            LOG.error(EVENT, "An exception occurred while using the parse_ion processor on Event [{}]", context, e);
+            LOG.error(SENSITIVE, "An exception occurred while using the parse_ion processor while parsing [{}]", message, e);
             return Optional.empty();
         }
     }

data-prepper-plugins/parse-json-processor/src/main/java/org/opensearch/dataprepper/plugins/processor/parse/json/ParseJsonProcessor.java

@@ -5,23 +5,23 @@
 
 package org.opensearch.dataprepper.plugins.processor.parse.json;
 
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.core.type.TypeReference;
+import com.fasterxml.jackson.databind.ObjectMapper;
 import org.opensearch.dataprepper.expression.ExpressionEvaluator;
 import org.opensearch.dataprepper.metrics.PluginMetrics;
 import org.opensearch.dataprepper.model.annotations.DataPrepperPlugin;
 import org.opensearch.dataprepper.model.annotations.DataPrepperPluginConstructor;
 import org.opensearch.dataprepper.model.event.Event;
 import org.opensearch.dataprepper.model.processor.Processor;
-import com.fasterxml.jackson.core.JsonProcessingException;
-import com.fasterxml.jackson.core.type.TypeReference;
-import com.fasterxml.jackson.databind.ObjectMapper;
 import org.opensearch.dataprepper.plugins.processor.parse.AbstractParseProcessor;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 import java.util.HashMap;
 import java.util.Optional;
 
-import static org.opensearch.dataprepper.logging.DataPrepperMarkers.EVENT;
+import static org.opensearch.dataprepper.logging.DataPrepperMarkers.SENSITIVE;
 
 @DataPrepperPlugin(name = "parse_json", pluginType = Processor.class, pluginConfigurationType = ParseJsonProcessorConfig.class)
 public class ParseJsonProcessor extends AbstractParseProcessor {
@@ -41,10 +41,10 @@ protected Optional<HashMap<String, Object>> readValue(String message, Event cont
         try {
             return Optional.of(objectMapper.readValue(message, new TypeReference<>() {}));
         } catch (JsonProcessingException e) {
-            LOG.error(EVENT, "An exception occurred due to invalid JSON while reading event [{}]", context, e);
+            LOG.error(SENSITIVE, "An exception occurred due to invalid JSON while parsing [{}] due to {}", message, e.getMessage());
             return Optional.empty();
         } catch (Exception e) {
-            LOG.error(EVENT, "An exception occurred while using the parse_json processor on Event [{}]", context, e);
+            LOG.error(SENSITIVE, "An exception occurred while using the parse_json processor while parsing [{}]", message, e);
             return Optional.empty();
         }
     }

data-prepper-plugins/parse-json-processor/src/main/java/org/opensearch/dataprepper/plugins/processor/parse/xml/ParseXmlProcessor.java

@@ -16,7 +16,7 @@
 import java.util.HashMap;
 import java.util.Optional;
 
-import static org.opensearch.dataprepper.logging.DataPrepperMarkers.EVENT;
+import static org.opensearch.dataprepper.logging.DataPrepperMarkers.SENSITIVE;
 
 @DataPrepperPlugin(name = "parse_xml", pluginType =Processor.class, pluginConfigurationType =ParseXmlProcessorConfig.class)
 public class ParseXmlProcessor extends AbstractParseProcessor {
@@ -36,10 +36,10 @@ protected Optional<HashMap<String, Object>> readValue(final String message, fina
         try {
             return Optional.of(xmlMapper.readValue(message, new TypeReference<>() {}));
         } catch (JsonProcessingException e) {
-            LOG.error(EVENT, "An exception occurred due to invalid XML while reading event [{}]", context, e);
+            LOG.error(SENSITIVE, "An exception occurred due to invalid XML while parsing [{}] due to {}", message, e.getMessage());
             return Optional.empty();
         } catch (Exception e) {
-            LOG.error(EVENT, "An exception occurred while using the parse_xml processor on Event [{}]", context, e);
+            LOG.error(SENSITIVE, "An exception occurred while using the parse_xml processor while parsing [{}]", message, e);
             return Optional.empty();
         }
     }